Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain - Add IOTA-core docs #1551

Merged
merged 26 commits into from
May 15, 2024
Merged

Maintain - Add IOTA-core docs #1551

merged 26 commits into from
May 15, 2024

Conversation

lucas-tortora
Copy link
Collaborator

@lucas-tortora lucas-tortora commented May 8, 2024 •
edited

Description of change

  • Added IOTA core docs
  • Added IOTA core validator setup guide
  • Updated the docker setup guide

TODO

  1. Update testnet info
  2. Add CLI-wallet link
  3. Update API Ref link
  4. Review config and peering

Type of change

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@lucas-tortora lucas-tortora marked this pull request as draft May 8, 2024 14:29
@lucas-tortora lucas-tortora marked this pull request as ready for review May 8, 2024 14:29
@lucas-tortora lucas-tortora marked this pull request as draft May 8, 2024 14:38
@lucas-tortora lucas-tortora marked this pull request as ready for review May 8, 2024 14:38
PhilippGackstatter
PhilippGackstatter approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mana allotment still needs more instructions but those can be added later and doesn't need to happen in this PR, so from my side, it looks good.

docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
@Dr-Electron Dr-Electron marked this pull request as draft May 13, 2024 08:59
@Dr-Electron Dr-Electron marked this pull request as ready for review May 13, 2024 08:59
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c36520a

✅ Preview: https://iota-wiki-ecb8cmc98-iota1.vercel.app

Dr-Electron
Dr-Electron requested changes May 13, 2024
View reviewed changes
docs/maintain/iota-core/2.0/docs/how_tos/post_installation.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/post_installation.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/post_installation.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/post_installation.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/post_installation.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/how_tos/validator_setup.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/references/api_reference.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/docs/welcome.md Outdated Show resolved Hide resolved
docs/maintain/iota-core/2.0/sidebars.js Outdated Show resolved Hide resolved
versionedConfig.js Outdated Show resolved Hide resolved
lucas-tortora and others added 2 commits May 13, 2024 15:37
@lucas-tortora @Dr-Electron
Apply suggestions from code review
8f5e178 
Co-authored-by: Dr-Electron <dr-electr0n@protonmail.com>
@lucas-tortora
unify spelling
c8b6bfc 
fix api
Dr-Electron
Dr-Electron approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dr-Electron Dr-Electron marked this pull request as draft May 13, 2024 19:12
@Dr-Electron Dr-Electron marked this pull request as ready for review May 13, 2024 19:12
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5c01228

✅ Preview: https://iota-wiki-7d9hsq7rc-iota1.vercel.app

@Dr-Electron Dr-Electron marked this pull request as draft May 14, 2024 15:24
@Dr-Electron Dr-Electron marked this pull request as ready for review May 14, 2024 15:24
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 55e13e3

✅ Preview: https://iota-wiki-pg1m4rpom-iota1.vercel.app

@Dr-Electron Dr-Electron marked this pull request as draft May 15, 2024 00:07
@Dr-Electron Dr-Electron marked this pull request as ready for review May 15, 2024 00:07
Dr-Electron
Dr-Electron requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the TODO has to be resolved.
Everything else seems to work for me. Although I'm waiting for mana all the time 😅

docs/maintain/iota-core/2.0/docs/how_tos/using_docker.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 76e738d

✅ Preview: https://iota-wiki-a7pv51xrh-iota1.vercel.app

@Dr-Electron Dr-Electron merged commit 613a0a3 into main May 15, 2024
12 checks passed
@Dr-Electron Dr-Electron deleted the maintain/add-iota-core branch May 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsporn alexsporn alexsporn left review comments

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@Ginowine Ginowine Awaiting requested review from Ginowine

@jlvandenhout jlvandenhout Awaiting requested review from jlvandenhout

@vivekjain23 vivekjain23 Awaiting requested review from vivekjain23

@PhilippGackstatter PhilippGackstatter Awaiting requested review from PhilippGackstatter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lucas-tortora @alexsporn @PhilippGackstatter @Dr-Electron