Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core contract refs #1538

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update core contract refs #1538

wants to merge 2 commits into from

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

Updated the docs to iotaledger/wasp#3336

Links to any relevant issues

Fixes #1535

Type of change

  • Documentation Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work

@Dr-Electron
Copy link
Collaborator Author

One open question. Does nativeTokenCreate have a return value? If so it is missing in https://github.com/iotaledger/wasp/blob/af9f243b453fd5e031c1f680893f3bfd86e287ce/packages/wasmvm/wasmlib/interfaces/coreaccounts.yaml#L49C3-L49C20

@Dr-Electron Dr-Electron requested a review from lmoe April 26, 2024 14:42
@Dr-Electron Dr-Electron marked this pull request as ready for review April 26, 2024 14:51
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c9a7b2f

✅ Preview: https://iota-wiki-c097axw95-iota1.vercel.app

@Dr-Electron Dr-Electron marked this pull request as draft May 6, 2024 08:00
@Dr-Electron Dr-Electron marked this pull request as ready for review May 6, 2024 08:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

This pull request has been deployed to Vercel.

Latest commit: 6543765

✅ Preview: https://iota-wiki-fnmbh4aia-iota1.vercel.app

@Dr-Electron Dr-Electron marked this pull request as draft May 6, 2024 08:14
lmoe
lmoe approved these changes May 7, 2024
View reviewed changes
Copy link

@lmoe lmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM :)

docs/build/isc/v1.0.0-rc.6/docs/reference/core-contracts/accounts.md

#### Parameters

- `t` ([`iotago::TokenScheme`](https://github.com/iotaledger/iota.go/blob/develop/token_scheme.go)): The token scheme
- `t` ([`bytes`](https://github.com/iotaledger/iota.go/blob/develop/token_scheme.go)): The token scheme
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed to bytes? It's still the same TokenScheme.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably same reason why I didn't add the return value in the beginning. It wasn't in the above mentioned yaml 😅

I can change it back 🤔

Suggested change
- `t` ([`bytes`](https://github.com/iotaledger/iota.go/blob/develop/token_scheme.go)): The token scheme
- `t` ([`iotago::TokenScheme`](https://github.com/iotaledger/iota.go/blob/develop/token_scheme.go)): The token scheme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoe lmoe lmoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update token docs for wasp
2 participants
@Dr-Electron @lmoe