Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block issuer key from bytes conversion #2249

Merged
merged 2 commits into from
May 14, 2024

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Allow inputting an Ed25519 Public Key and use the hash of it as the block issuer key.

Links to any relevant issues

n/a

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M requested a review from Alex6323 May 14, 2024 07:52
@Thoralf-M Thoralf-M merged commit bdda695 into iotaledger:2.0 May 14, 2024
37 checks passed
@Thoralf-M
Copy link
Member

Thanks!

@PhilippGackstatter PhilippGackstatter deleted the fix-block-issuer-key branch May 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants