New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up wallet syncing code #2108

Merged

Alex6323 merged 46 commits into iotaledger:2.0 from Alex6323:cleanup-wallet-syncing

Apr 30, 2024

Contributor

Alex6323 commented Mar 1, 2024 •

edited

Description of change

An attempt at cleaning up some wallet syncing code.

Links to any relevant issues


          const fn

1badfa3

Alex6323 linked an issue

that may be closed by this pull request

Cleanup wallet syncing code #1905

Open


          sync options

bb673e2

Alex6323 force-pushed the cleanup-wallet-syncing branch from a647798 to bb673e2 Compare

March 1, 2024 16:37

Alex6323 added 11 commits

March 13, 2024 10:05


          Merge branch '2.0' into cleanup-wallet-syncing

9b77ea1


          move instead of clone


          combinators

264b2d9


          rm unnecessary cloning 1

010e276


          rm unnecessary cloning 2

abe5f40


          slices; impl Into<Option>

c5e38fb


          refactor

55b5a2f


          get rid of output_data

8591c86


          Merge branch '2.0' into cleanup-wallet-syncing

7a158a6


          nits

38afbb8


          clippy

1cb8c67

Alex6323 marked this pull request as ready for review

March 14, 2024 22:03

nit

52e0afb

Thoralf-M reviewed

View reviewed changes

bindings/core/src/response.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/types/address.rs Show resolved Hide resolved

Alex6323 added 2 commits

March 15, 2024 10:56


          nest

99561d7

nit

afe5ada

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/operations/syncing/addresses/output_ids/account_foundry.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/operations/syncing/addresses/output_ids/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/types/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/operations/syncing/addresses/output_ids/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/types/address.rs Outdated Show resolved Hide resolved

Alex6323 added 4 commits

March 15, 2024 11:57


          update python binding

e7e592f


          update nodejs binding

0cc5e29


          update core binding

2f1c6e9


          rm output_data.py

dea3c64


          Merge branch '2.0' into cleanup-wallet-syncing

b923a00

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/operations/syncing/mod.rs Outdated Show resolved Hide resolved

Alex6323 and others added 3 commits

March 22, 2024 12:01


          Merge branch '2.0' into cleanup-wallet-syncing

d12be48


          remove todo

0159dc9


          Merge branch '2.0' into cleanup-wallet-syncing

94de389

DaughterOfMars reviewed

View reviewed changes

bindings/python/iota_sdk/types/output_with_extended_metadata.py Outdated Show resolved Hide resolved

DaughterOfMars reviewed

View reviewed changes

Contributor

DaughterOfMars left a comment

tbh I don't like the name. Maybe ExtendedOutputMetadata would be better? I would even be happier just leaving it OutputData...


          Merge branch '2.0' into cleanup-wallet-syncing

48b6661

Contributor Author

Alex6323 commented Mar 27, 2024 •

edited

tbh I don't like the name. Maybe ExtendedOutputMetadata would be better? I would even be happier just leaving it OutputData...

yeah, believe me when I say I am not fond of this name either, but I remember us all not really liking ...Data types (looking at you WalletData), because that's just a lazy name giving you no clue at all about what it contains, i.e. everything is data.

Anyways in this case we can make an exception, I guess 🤷‍♂️

Member

thibault-martinez commented Mar 27, 2024

tbh I don't like the name. Maybe ExtendedOutputMetadata would be better? I would even be happier just leaving it OutputData...

yeah, believe me when I say I am not fond of this name either, but I remember us all not really liking ...Data types (looking at you WalletData), because that's just a lazy name giving you no clue at all about what it contains, i.e. everything is data.

Anyways in this case we can make an exception, I guess 🤷‍♂️

But we said we'll revert the rename anyway?

Alex6323 added 3 commits

April 15, 2024 15:55


          undo rename

e91b2af


          Merge branch 'upstream/2.0' into cleanup-wallet-syncing

ea08631


          Merge branch '2.0' into cleanup-wallet-syncing

c3f0ae6

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/lib/types/wallet/output.ts Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/python/iota_sdk/types/output_with_extended_metadata.py Outdated Show resolved Hide resolved

Alex6323 added 6 commits

April 26, 2024 16:16


          Merge branch 'upstream/2.0' into cleanup-wallet-syncing

94419c4


          rust: cleanup

d7f4443


          python: cleanup

9e0e4e3


          nodejs: cleanup

f69965a


          Merge branch '2.0' into cleanup-wallet-syncing

346ab5f


          rust: more cleanup

38b7bfc

Thoralf-M reviewed

View reviewed changes

cli/src/wallet_cli/mod.rs Outdated Show resolved Hide resolved

Alex6323 added 4 commits

April 30, 2024 10:52


          Merge branch '2.0' into cleanup-wallet-syncing

5de120c

...

a9100c3


          ....

b745c52


          .....

6412d7c

Thoralf-M approved these changes

View reviewed changes

DaughterOfMars approved these changes

View reviewed changes

Alex6323 merged commit 3e44c80 into iotaledger:2.0

37 checks passed

Alex6323 deleted the cleanup-wallet-syncing branch

April 30, 2024 14:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment