feat/Python: Add pylint to code #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2023 14:26
Thoralf-M
reviewed
Sep 25, 2023
Thoralf-M
reviewed
Sep 25, 2023
Thoralf-M
previously approved these changes
Sep 25, 2023
Thoralf-M
approved these changes
Sep 26, 2023
Closed
thibault-martinez
approved these changes
Sep 26, 2023
abdulmth
approved these changes
Sep 26, 2023
Alex6323
approved these changes
Sep 26, 2023
kwek20
pushed a commit
to kwek20/iota-sdk
that referenced
this pull request
Oct 9, 2023
* moved pylint to root * lints * pylint fixes * final fixes * autopep format * fixes for irc and delegation * changed to better ABC layout * some gh actions only error?? --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
thibault-martinez
added a commit
that referenced
this pull request
Oct 25, 2023
* moved pylint to root * feat/Python: Add pylint to code (#1315) * moved pylint to root * lints * pylint fixes * final fixes * autopep format * fixes for irc and delegation * changed to better ABC layout * some gh actions only error?? --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * fixes for develop * reverts * lint * reverted range * docs * format * comment * some more doc fix * todo comment on disable * changed docs * Update bindings/python/iota_sdk/wallet/account.py Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> * 2 review comments * format * pep again? * fmt x2 * final lints * removed test * review * revert * 1 more * Update bindings/python/iota_sdk/types/unlock.py * Update bindings/python/iota_sdk/types/irc_30.py * changelog --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com> Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com> Co-authored-by: Thibault Martinez <thibault@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds
lint-sdkphase in tox, to check the code during a prUpdates all code to be compliant with the check
Links to any relevant issues
fixes #1236