chore: update info boxes for stardust. #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Panteleymonchuk <panteleymonchuk@gmail.com>
brancoder
requested changes
May 17, 2024
| @@ -4,7 +4,7 @@ | |||
| "links": [ | |||
| { | |||
| "label": "Read more", | |||
| "href": "https://wiki.iota.org/iota.rs/explanations/address_key_space", | |||
| "href": "https://github.com/iotaledger/tips/blob/main/tips/TIP-0031/tip-0031.md", | |||
There was a problem hiding this comment.
maybe we could use wiki links instead of github links where relevant, like you did in metadata.json:
https://github.com/iotaledger/tips/blob/main/tips/TIP-0031/tip-0031.md change to https://wiki.iota.org/tips/tips/TIP-0031
this can be applied to other files where it makes sense
There was a problem hiding this comment.
It makes sense, I'll change it
Signed-off-by: Eugene Panteleymonchuk <panteleymonchuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Closes #1442
Type of change
How the change has been tested
Make sure that all links valid.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.