Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nova ci debris #1480

Merged
merged 3 commits into from
May 17, 2024
Merged

chore: remove nova ci debris #1480

merged 3 commits into from
May 17, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented May 14, 2024

Description of change

Fixes #1474

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Refactor

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove setup_nova.sh, we should cleanup its debris in package.json, there are still some references to it

@VmMad VmMad requested a review from begonaalvarezd May 16, 2024 08:42
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit cabd349 into main May 17, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/remove-nova-ci branch May 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove nova CI debris
3 participants