Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for maintaining consistency #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nujabes403
Copy link
Contributor

There are some code which is not consistent another codes.
For example,

1) Separation key & colon

  • When defining property of object, all codes have a space between key and :.

Good example)

    RPC: RPC,
    HTTPProvider: HTTPProvider,
    KeyPair: KeyPair,

Bad example)
There are some code which is not, like Tx : Tx,

2) Separation comma & argument

  • When separating arguments with comma, add space between , and argument.

Good example)

c.pushBytes(this.sig, true);

Bad example)

this.sig = Buffer.from(nacl.sign(info, keyPair.seckey)).slice(0,64);

After this PR, all codes have consistency for 1) Separation key & colon, 2) Separation comma & argument

@nujabes403
Copy link
Contributor Author

Pleas take a look @flybikeGx @sswsdsn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant