Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ion-vue-router #17821

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Conversation

michaeltintiuc
Copy link
Contributor

@michaeltintiuc michaeltintiuc commented Mar 19, 2019

Usage

There are no major changes to usage:

<ion-vue-router />

There are 2 properties that ion-vue-router accepts:

  • name - the name of the view, which is passed to router-view as per VueRouter docs
  • animated - disables animations, the value is passed to ion-router-outlet
<ion-vue-router name="myView" animated="false" />

Changes

  • Refactor ion-vue-router into a functional component which yields a performance boost as per Vue docs.
  • Improve ionic transitions between routes, this mainly fixes the issue of navigation while a transition is in progress.
  • Update router interface
  • Improve Promise error handling for ion-router-outlet transitions
  • Remove transitionless router as in hind sight it is really unneeded
  • Remove unnecessary router options
  • Remove support for in-browser support as ionic itself does not support this
  • Update rollup config as per this issue

@ionitron-bot ionitron-bot bot added the package: vue @ionic/vue package label Mar 19, 2019
@jthoms1 jthoms1 self-requested a review March 22, 2019 15:11
@mhartington mhartington merged commit 71e5994 into ionic-team:master Mar 22, 2019
kiku-jw pushed a commit to kiku-jw/ionic that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants