Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(modal): add docs for using nav in modal #12747

Merged
merged 1 commit into from Sep 1, 2017

Conversation

wbhob
Copy link

@wbhob wbhob commented Aug 25, 2017

Short description of what this resolves:

I added documentation on how to use a modal container component in an Ionic app. This has had a lot of discussion in #8151, and is minimally documented, so I took a stab at documenting it.

Changes proposed in this pull request:

  • add documentation on navigating inside modal

Ionic Version: 1.x / 2.x / 3.x

Fixes: #8151

I added documentation on how to use a modal container component in an Ionic app. This has had a lot of discussion in ionic-team#8151, and is minimally documented, so I took a stab at documenting it.
@wbhob wbhob changed the title Update modal-controller.ts docs(modal): add docs for using nav in modal Aug 25, 2017
@mhartington mhartington merged commit 4f49f27 into ionic-team:master Sep 1, 2017
@wbhob wbhob deleted the patch-2 branch September 1, 2017 17:29
@wbhob
Copy link
Author

wbhob commented Sep 1, 2017

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants