Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic import in hooks for type module projects #5084

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

frederikbosch
Copy link

@frederikbosch frederikbosch commented Mar 19, 2024

When using ionic + vue, the hooks serve:before scripts defined in ionic.config.json cannot run.

ionic.config.json

  "hooks": {
    "serve:before": ["./scripts/serve-before.js"]
  }

serve-before.js:

export default async function (ctx) {
}

This setup generates the following error:

[ERROR] An error occurred while running an Ionic CLI hook defined in ./ionic.config.json.
        
        Hook: serve:before
        File: /srv/libraries/app-ionic/scripts/install-custom.js
        
        Error [ERR_REQUIRE_ESM]: require() of ES Module /srv/libraries/app-ionic/scripts/serve-before.js from
        /srv/libraries/app-ionic/node_modules/@ionic/cli/lib/hooks.js not supported.
        Instead change the require of install-custom.js in
        /srv/libraries/app-ionic/node_modules/@ionic/cli/lib/hooks.js to a dynamic import() which is available in
        all CommonJS modules.
        at ServeBeforeHook.loadHookFn (/srv/libraries/app-ionic/node_modules/@ionic/cli/lib/hooks.js:73:24)

Switching back to require and module.exports style nodejs is not possible, because of the project type in the package.json.

"type": "module",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant