Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Yarn v2 and Yarn v3 #4892

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

Losses
Copy link

@Losses Losses commented Jul 19, 2022

This pull request enables user to use yarn berry (aka yarn v2 and yarn v3) as their package manager, and fixed #4483

This pull request enables user to use yarn berry (aka yarn v2 and yarn v3) as their package manager, and fixed ionic-team#4483
@mklueh
Copy link

mklueh commented Dec 12, 2022

Can this please be merged? Very inconvenient having to patch things to get ionic working with berry

@IT-MikeS
Copy link
Contributor

IT-MikeS commented Apr 4, 2023

Definitions need to be updated for the new pkgManager entry and a test app/instructions need to be added so this can be reviewed.

@Losses
Copy link
Author

Losses commented Apr 5, 2023

Definitions need to be updated for the new pkgManager entry and a test app/instructions need to be added so this can be reviewed.

Sure, we can test if this works with the following steps:

  1. Create an empty ionic application with Yarn v1;
  2. Run the following command:
 yarn set version berry
  1. Try to build the application and see if any error emerges.

@IT-MikeS
Copy link
Contributor

IT-MikeS commented Apr 5, 2023

Going to need much more detailed testing steps. include install instructions, build/pack instructions, what to expect before and after fix is applied, reproduction repo, etc. These exact commands/examples/reproductions will speed this along.

@MarcusAngel
Copy link

Any progress on this... kinda crazy its taken this long

@hichemfantar
Copy link

hichemfantar commented Aug 7, 2023

Can we get some movement on this please. This is critical because the project I'm working on is a huge monorepo with yarn v3.
Edit: I tested the code and it works by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible option for yarn v2
5 participants