Certificate generation requires completion criteria

[jackawardls]

$trackinfo was too loose in the SQL query for retrieving track data. This would cause a cron-generated certificate to show incorrect (0% score, and invalid date) data to appear in the certificate if an attempt to generate the certificate manually was made before the user completed the course. The existing way to avoid this is to manually regenerate the certificate.

This code will check if a record was returned from the iomad_track table that has a 'timecompleted' value and will return true to signify a certificate was generated and false for the opposite.

*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***

The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.

See CONTRIBUTING.txt guidelines for how to contribute patches for Moodle. Thank you.

--

[turf212]

Can you please neaten up the DB call in line 173 so that it is passing proper parameters to the $DB class call. Also the SQL you have will only work on certain DBs so that needs to change too.

E.g. can change 173 -175 to be:

if ($trackinfos = $DB->get_records_sql("SELECT * FROM {local_iomad_track}
                                                           WHERE id = :trackid
                                                           AND timecompleted IS NOT NULL",
                                                           array('trackid' => $trackid),
                                                           0, 1))) {

	$trackinfo = current($trackinfos);

[jackawardls]

Ok no problem, will make the requested PR changes as soon as possible from both PR's.
Apologies for if the web-based PR's are an issue, I have had troubles cloning Iomad to my Windows machine!