Iomad 35 stable #1131
Open
Iomad 35 stable #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge performance improvement for behat. The current set of steps loads the page It then looks for the Classic/Clean version of the settings menu If it fails to find it looks for the Boost Cog Then it clicks the "Turn editing on" button This can take a substantial period. We do not actually need to run these steps as we are able to jump straight to the URL. We already have access to the sesskey value required to do this. There is not loss in testing functionality because the actual testing of the Turn editing functionality is tested in other places sufficiently.
…nto MOODLE_35_STABLE
…nto MOODLE_35_STABLE
…nto MOODLE_35_STABLE
…nto MOODLE_35_STABLE
…/moodle-install into MOODLE_35_STABLE
…OODLE_35_STABLE
Both ldap or the DB can return information in a non-consistent ordering leading to events to be generated in different order. And current tests are, right now, assuming a given order. Note this is a rare random, but it's happening, so better fix it, see the issue for some more details. So we just do the tests ordering immune, verifying that all the expected events have been triggered and done. Irrespectively of their order.
This is a direct copy of the 3.9 branch to have changes under control easier for next commits.
- mysql requirement up to 5.7 - postgres requirement up to 9.6
The result of the final command `script` phase determines the build result. The cleanup belongs in the `after_script` phase.
Ensure we are using the ID of the given user rather than falling back to that of the current user during privacy export.
…/moodle-install into MOODLE_35_STABLE
This improves the code and avoids the risk of SQL injection through the malicious XML-RPC request from the MNet peer.
Change the yes/no dropdowns to a checkbox. Defaults to unchecked.
…nto MOODLE_35_STABLE
… MOODLE_35_STABLE
…/moodle-install into MOODLE_35_STABLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.txt guidelines for how to contribute patches for Moodle. Thank you.
--