Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple improvements on exported types #2738

Merged
merged 19 commits into from
May 29, 2024
Merged

multiple improvements on exported types #2738

merged 19 commits into from
May 29, 2024

Conversation

GermanBluefox
Copy link
Contributor

No description provided.

@foxriver76 foxriver76 self-requested a review May 16, 2024 15:55
packages/types-dev/objects.d.ts Outdated Show resolved Hide resolved
@foxriver76 foxriver76 changed the title Extend adminTab object with i18n name multiple improvements on exported types May 19, 2024
@GermanBluefox
Copy link
Contributor Author

@foxriver76 @Apollon77 what is with this PR?

@foxriver76
Copy link
Collaborator

foxriver76 commented May 29, 2024

CI is failing @GermanBluefox

i would strongly recommend to put the ids back to simple strings for now

@GermanBluefox
Copy link
Contributor Author

CI is failing @GermanBluefox

i would strongly recommend to put the ids back to simple strings for now

Done

@foxriver76 foxriver76 merged commit b38e017 into master May 29, 2024
12 checks passed
@foxriver76 foxriver76 deleted the admin-tab-type branch May 29, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants