Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Prepare controller v6 Kiera #2735

Merged
merged 7 commits into from
May 22, 2024
Merged

[chore]: Prepare controller v6 Kiera #2735

merged 7 commits into from
May 22, 2024

Conversation

foxriver76
Copy link
Collaborator

No description provided.

@foxriver76 foxriver76 changed the title [chore]: Prepare controlloer v6 Kiera [chore]: Prepare controller v6 Kiera May 15, 2024
@foxriver76 foxriver76 requested a review from Apollon77 May 15, 2024 17:35
@mcm1957
Copy link
Contributor

mcm1957 commented May 15, 2024

Ev. add to BREAKING CHANGE and/or developer news
common.subscribe and mode=subscribe and common.wakeup have been removed (*)
adapter-core >= 3.1.4 required

(*) there seem to exits adapters still using siubscribe:messagebox. Repochecker can detect it.

CHANGELOG.md Outdated
## __WORK IN PROGRESS__ - Kiera

**Breaking changes**
* Support for Node.JS 16 is dropped!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Support for Node.JS 16 is dropped!
* Support for Node.js 16 is dropped!

CHANGELOG.md Outdated
**Features**
* (foxriver76) Added possibility to automatically upgrade adapters (see https://github.com/ioBroker/ioBroker.js-controller?tab=readme-ov-file#automatic-adapter-upgrade)
* (foxriver76) if updates for OS packages are available a notification is generated (Linux only)
* (foxriver76) js-controller (and thus the whole ioBroker) is now running as an ESM module internally while staying a 100 % backward compatible to adapters written in cjs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this to the developer section

CHANGELOG.md Outdated
* (foxriver76/bluefox/Apollon77) minor fixes and stability improvements

**Developer relevant DEPRECATIONS/WARNINGS**
* (foxriver76) adapters need to use `adapter-core` version 3.1.4 or higher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the peer deps maybe "telling 3.x (ideally 3.1.4+)" or such is sufficient?

CHANGELOG.md Outdated
* (foxriver76) js-controller (and thus the whole ioBroker) is now running as an ESM module internally while staying a 100 % backward compatible to adapters written in cjs
* (foxriver76) the controller creates a notification if free disk space is critical (see https://github.com/ioBroker/ioBroker.js-controller?tab=readme-ov-file#disk-space-warnings)
* (foxriver76) allow to ignore specific adapter versions (see https://github.com/ioBroker/ioBroker.js-controller?tab=readme-ov-file#ignoring-specific-adapter-version)
* (foxriver76) generate notification if an adapter is blocklisted and thus stopped
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would turn that around because foirst of all we stop adapters nochactively .. and generate notifies, right?

CHANGELOG.md Outdated
* (foxriver76) we provide all exports as ESM and as CJS to allow adapter developers to choose what to use
* (foxriver76) added convenient methods to manage node modules (see https://github.com/ioBroker/ioBroker.js-controller?tab=readme-ov-file#managing-node-modules)
* (foxriver76) allow to specify reason and exit code on `adapter.stop`
* (foxriver76) if you blocklist a version in the repository the controller won't start it anymore and will generate a notification
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... in your package.json and publish to github"? instead "repository"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io-pack yeah makes sense

* (foxriver76) added convenient methods to manage node modules (see https://github.com/ioBroker/ioBroker.js-controller?tab=readme-ov-file#managing-node-modules)
* (foxriver76) allow to specify reason and exit code on `adapter.stop`
* (foxriver76) if you blocklist a version in the repository the controller won't start it anymore and will generate a notification
* (foxriver76) for adapters of type `schedule` and `connectionType` set to `cloud` the schedule will be automatically delayed by up to 60 seconds randomly per user if the CRON does not contain a seconds argument, this is to prevent DDoS attacks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we then update the weather adapters that got manually added a delay logic adjust to set seconds?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the workarounds their then but this requires controller v6 then of course, so maybe keep it for now?

@foxriver76 foxriver76 merged commit 04f0eac into master May 22, 2024
12 checks passed
@foxriver76 foxriver76 deleted the foxriver76-patch-1 branch May 22, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants