Test/signup functional test #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 24, 2016 08:09
sinon.spy() => sinon.spy(Object, method)
add file src/components/auth/registerUser.functional.spec.js add file .travis.yml for travis-ci
remove $q remove makeDeferred In this test both of them do not require.
| controller.checkEmail(); | ||
| $httpBackend.flush(); | ||
| $rootScope.$digest(); | ||
| expect(controller.emailIsValid).to.eq(true); |
There was a problem hiding this comment.
Line 68 to 81 and line 83 to 95 should be separated to different it() sections.
…emplate. Remove some testing which is for unit test. Change first argument of it() with a meaningful sentence. Let sign-up controller has a compile template.
|
This PR has conflicts. Please resolve it. |
added 6 commits
April 26, 2016 01:42
Conflicts: .travis.yml src/components/auth/signin/signin.spec.js src/components/auth/signup/signup.spec.js
|
i can't solve this branch confilcts. i will create a new branch and new PR |
update unit test in signin and signup solve confilcts in .travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.