Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose changes #6043

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

mcmikemn
Copy link

@mcmikemn mcmikemn commented Mar 24, 2024

Summary

I'm not a coder so these changes definitely need to be reviewed before being accepted!

  1. I couldn't get run.sh to succeed, and it looked like this line was building the --build-args statement but the following lines needed the values in those args as well. So I replaced that line with a while that builds the --build-args statement and assigns the vals to the vars.
  2. I also had to change the service name from invokeai-nvidia to invokeai-cuda. Despite the comment in the .env file saying that the values should be "nvidia" or "rocm", "nvidia" doesn't work but "cuda" does. This line may be the reason that "cuda" is required. And since $GPU_DRIVER must be set to "cuda" for an Nvidia GPU, $profile is set based on $GPU_DRIVER, and $service_name is set based on $profile, $service_name ends up being invokeai-cuda (not invokeai-nvidia).
  3. I also added compose.override.yaml to run.sh in case a user has such a need. I use Traefik as proxy and middleware plugins ipwhitelist and traefik-forward-auth, so I use compose.override.yaml so that I don't have to modify docker-compose.yaml and thus have git telling me I need to commit a change.

Related Issues / Discussions

NA

QA Instructions

NA

Merge Plan

NA

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants