Fix secondary fonts for Invoice Design preview #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
If a secondary font is used in the Invoice Design settings, it works in the Custom Design editor, but the preview in General Settings always shows Roboto in place of the secondary font, regardless of settings. This updates PdfMock to also support secondary fonts on the main tab.
dshoreman
force-pushed
the
ds/fix-secondary-font-preview
branch
from
a1e6837
to
9bad087
Compare
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a secondary font is used in the Invoice Design settings, it works fine in the Custom Design editor.
The preview in General Settings though, always uses Roboto for the secondary font, regardless of settings.
This PR updates
PdfMockto also support secondary fonts on the main tab.