Replaced mktemp with mkstemp

[fazledyn-or]

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file(s): mask.py, slice_.py, styles.py, surface.py, imagedata_utils.py, surface_process.py, bitmap_reader.py, project.py, segment.py, there is a method that creates a temporary file using an unsafe API mktemp. The use of this method is discouraged in the Python documentation. iCR suggested that a temporary file should be created using mkstemp which is a safe API. iCR replaced the usage of mktemp with mkstemp.

Here are a few reasons why you shouldn't use mktemp

• POC - Improper Method Call - python - mktemp.mp4
• MISC - Python - Taking a peek under the tempfile library.mp4

Changes

• Replaced method mktemp with a safer method: mkstemp
• Closed the file-descriptors associated with mkstemp to prevent file-descriptor leaks

Testing

No tests were performed due to lack of documentation/script. With proper guidance, I'd be happy to test the code on your behalf.

Previously Found & Fixed

• azure-linux-extensions

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

[tfmoraes]

Thanks @fazledyn-or!