Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group support to communication notifications #1017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

focux
Copy link

@focux focux commented Mar 30, 2024

Hey!

I was trying to add a subtitle/group name to my communication notifications and found out that notifee doesn't support it at the moment so in this PR I added support for it.

Related issues #889 #865

For context, here is an image of what I'm talking about:
image

@focux focux changed the title Add support for groupName/subtitle to communication notifications feat: group name/subtitle support to communication notifications Mar 30, 2024
@focux focux force-pushed the add-support-for-communication-group-name branch from 3077a85 to 5dc18cb Compare March 30, 2024 23:31
@focux focux force-pushed the add-support-for-communication-group-name branch from 5dc18cb to 743ef03 Compare March 31, 2024 04:32
@focux focux changed the title feat: group name/subtitle support to communication notifications feat: group support to communication notifications Mar 31, 2024
Copy link

@mattlennon3 mattlennon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Any documentation updates to be done?

Copy link

github-actions bot commented May 7, 2024

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 7, 2024
@focux
Copy link
Author

focux commented May 15, 2024

not stale

@github-actions github-actions bot removed the Stale label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants