build(custom_runner): armv7 & armv8 Linux precompilation (#1) #3

Salakar · 2024-04-21T00:56:46Z

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

…2/64

Salakar · 2024-04-22T14:11:54Z

.github/workflows/cpp-packaging.yml

@@ -699,7 +734,7 @@ jobs:

  merge_packages:
    name: final-merge-packages
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest-m


Suggested change

runs-on: ubuntu-latest-m

runs-on: ubuntu-latest-m

Not enough disk space on default runner now with new arches, so using GitHub provided Large Runners here, but requires setup on each with a custom runner name (can all be done through GitHub UI)

Salakar · 2024-04-22T14:14:37Z

.github/workflows/cpp-packaging.yml

@@ -802,7 +837,49 @@ jobs:
        with:
          name: firebase_cpp_sdk_windows.zip
          path: firebase_cpp_sdk_windows.zip
-
+  create_linux_only_package:


Added a linux only packaging step

Salakar · 2024-05-05T13:30:56Z

app/src/filesystem_desktop_linux.cc

@@ -55,7 +55,7 @@ std::string HomeDir(std::string* out_error) {
 std::string XdgDataHomeDir(std::string* out_error) {
  const char* data_home = getenv("XDG_DATA_HOME");
  if (data_home) return data_home;
-  return "";
+  return "/data";


Can be ignored, was just testing if this fixed another issue, get bad_alloc with or without this

Salakar · 2024-05-05T13:31:55Z

cmake/toolchains/linux_64.cmake

+# Toolchain file for building 64-bit Linux libraries
+set (CMAKE_POSITION_INDEPENDENT_CODE ON)
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIC")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC -std=c++11")


-fPIC is required for the environment I'm building on

-std=c++11 added to see if resolved a bad_alloc crash - no affect with or without

Salakar · 2024-05-05T13:32:36Z

cmake/toolchains/linux_arm32.cmake

+# Toolchain file for building ARMv7 applications
+set (CMAKE_POSITION_INDEPENDENT_CODE ON)
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -march=armv7-a+fp -fPIC")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=armv7-a+fp -fPIC -std=c++11")


-fPIC is required for the environment I'm building on

-std=c++11 added to see if resolved a bad_alloc crash - no affect with or without

Salakar · 2024-05-05T13:32:55Z

cmake/toolchains/linux_arm64.cmake

+# Toolchain file for building ARMv8 applications
+set (CMAKE_POSITION_INDEPENDENT_CODE ON)
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -march=armv8-a -fPIC")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=armv8-a -fPIC -std=c++11")


-fPIC is required for the environment I'm building on

-std=c++11 added to see if resolved a bad_alloc crash - no affect with or without

Salakar added 22 commits April 19, 2024 20:16

build: armv7 & armv8 Linux precompilation (#1)

b4cf0ba

chore: fix formatting

d816ecb

chore: fix formatting

0021491

chore: docker images for local builds

9aff81b

build: update CI build to include arm

b3f4189

chore: temp disable integration tests for linux arm

ab3e705

refactor: cleanup

e05e0e1

-

626ae2d

-

44a0674

-

d9bb47e

-

dd95721

-

bc7edc1

-

e9d9cc3

-

30a4404

-

552a348

-

4a5d29a

-

ca6dc78

-

00c4ad0

-

9a0b51e

fix: large runner for disk space

a3a5bb7

fix: update release cmakelists to target correct arch when linux arm3…

6fdef44

…2/64

-

e945b92

Salakar commented Apr 22, 2024

View reviewed changes

-

61cc869

Salakar force-pushed the arm64-runners branch 5 times, most recently from c115daa to b486ed1 Compare April 22, 2024 16:31

build: temp use large runners

338b01e

Salakar force-pushed the arm64-runners branch 4 times, most recently from ce26e99 to ae78b77 Compare April 23, 2024 02:03

disable windows for now

9426e05

Salakar force-pushed the arm64-runners branch from ae78b77 to 9426e05 Compare April 23, 2024 02:28

Salakar added 6 commits April 30, 2024 14:03

chore: tmp fix for linux where xdg not set

22009e9

-

e3e65ec

-

ba52308

-

b4c978c

-

b9a9325

-

11e319a

Salakar commented May 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(custom_runner): armv7 & armv8 Linux precompilation (#1) #3

build(custom_runner): armv7 & armv8 Linux precompilation (#1) #3

Salakar commented Apr 21, 2024

Salakar Apr 22, 2024 •

edited

Salakar Apr 22, 2024

Salakar May 5, 2024

Salakar May 5, 2024 •

edited

Salakar May 5, 2024

Salakar May 5, 2024

build(custom_runner): armv7 & armv8 Linux precompilation (#1) #3

Are you sure you want to change the base?

build(custom_runner): armv7 & armv8 Linux precompilation (#1) #3

Conversation

Salakar commented Apr 21, 2024

Description

Testing

Type of Change

Notes

Salakar Apr 22, 2024 • edited

Choose a reason for hiding this comment

Salakar Apr 22, 2024

Choose a reason for hiding this comment

Salakar May 5, 2024

Choose a reason for hiding this comment

Salakar May 5, 2024 • edited

Choose a reason for hiding this comment

Salakar May 5, 2024

Choose a reason for hiding this comment

Salakar May 5, 2024

Choose a reason for hiding this comment

Salakar Apr 22, 2024 •

edited

Salakar May 5, 2024 •

edited