[WIP] Task reorganise deduplicates #735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namely: check_entities -> check_human_duplicates check_entity.js -> check_human_duplicate collect_entities -> collect_human_duplicates
laying ground for "delete" type tasks this also renames the current "type" parameter to "entitiesType", this naming was here to avoid taking a decision about multi-words request parameters this commit chose camel case, but next commit is the alternative kebab possibility
since actions are already using kebab
…ment
not only `{ "ok": true }`
since checkEntity has more complex results
threshold value is based on elastic score to create a defined amount of tasks. Its important to reject those suggestions after automerge, as a conservative feature to not automerge too many tasks only based on suggestions with a high lexical score, to not wrongly merge homonyms
to be able to later create deduplicate human tasks
makes a reposability separation between hooks and endpoint. It keeps couch view keys simple (not having byUrisAndbyStateAndByType) while restricts the endpoint access to stateless (aka not arcchived) tasks. This is possible since the client does not need to access archived tasks for the moment, so the new couch view only returns non-archived tasks.
which is currently not in use by the client, but leaving it since entity layout will actually reuse it to display its own related tasks one day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for tasks related issues (namely #724 and #491) which will introduce another
type(in task document), namelydelete. This addition will involve several API changes, which this PR tries to address:by-type->by-entities-typeand move parameter andtypetoentities-typesee commit named "add a task type parameter"minimumScoreToAutogenerateconfig parameter to not auto generate too many entities (see 97a0e89)