[WIP] add inventory view cache #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlath
force-pushed
the
add-inventory-view-cache
branch
from
6474ec7
to
085746e
Compare
maxlath
force-pushed
the
master
branch
3 times, most recently
from
c8f6481
to
b0a9869
Compare
to allow independant use
to be able to pass a custom admin, typically for groups that where created with a custom user, instead of the one returned by `getUser`
…d inventory views before this, the itemsByDate arrays where concatenated one user after another thus loosing order as soon as several cached inventory view were aggregated
that's possibly some premature optimization, but it doesn't add much complexity
as its not used by the client
|
status update: waiting for the merge of #371 to rebase and restart work |
jum-s
force-pushed
the
add-inventory-view-cache
branch
from
085746e
to
9391b02
Compare
making the current cache testable to see if it was refreshed during entity claim update
in order to call refreshInventoryViewsFromEntity outside update claim controller - delete some obsolete tests since sanitize is tested - explicit endpoint on first test
starting with adding a claim to an entity refresh caches of all owners of item of this entity
jum-s
force-pushed
the
add-inventory-view-cache
branch
from
9391b02
to
0528ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds caching per user and access level (
public,network,private) to limit the amount of cached data while maximizing the cache hits:TODOs: bust cache on every events that might change the inventory view data: