[WIP] get_entity_type: enforce disagreements with Wikidata P31 typing #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlath
force-pushed
the
get-entity-type
branch
from
fe3ebec
to
cd06523
Compare
jum-s
requested changes
May 4, 2019
| isSerie = 'serie' in propertyTypes | ||
|
|
||
| # If it has 'edition of' claims, consider that it's an edition | ||
| if isEdition and claims['wdt:P629']? then return 'edition' |
There was a problem hiding this comment.
We might consider returning a undefined value as no wikidata edition are to be interpreted by inventaire has an edition. Inventaire would then consider this entity as a topic, not an edition, avoiding for example the possibility of adding it to a user's inventaire.
|
Some code to refactor |
maxlath
force-pushed
the
get-entity-type
branch
2 times, most recently
from
6ad40dc
to
9f7782b
Compare
especially, - an entity can't be an edition if it doesn't have wdt:P629 claims - prefer to consider an ambiguous entity as a serie rather than a work as it will be then easier to create subparts of this entity to which to link editions In the worst case, that was actually not a serie and subparts can be merged into it
maxlath
force-pushed
the
get-entity-type
branch
from
9f7782b
to
59fc3b5
Compare
maxlath
changed the title
by returning undefined instead of edition for wd entities - items that reference wikidata edition would need to be updated to reference their inv equivalents - that means keeping duplicated data with Wikidata, which is a bit sad. Implementing data synchronization would look a hell lot like "shadow items" The good side of the coin: - this does make some things simpler: looking for the editions of a work can be done on Inventaire only (which is already the case at this point but it wasn't clear if we would add Wikidata lookup at some point)
maxlath
force-pushed
the
get-entity-type
branch
from
59fc3b5
to
97f7219
Compare
|
@jum-s as you know I'm having doubts about the whole thing, please do not merge yet |
maxlath
force-pushed
the
master
branch
3 times, most recently
from
c8f6481
to
b0a9869
Compare
|
how should an entity that has both P31 Q20655472 and Q277759 (such as https://www.wikidata.org/wiki/Q11256364) be typed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
especially,
wdt:P629claimsas it will be then easier to create subparts of this entity to which to link editions
In the worst case, that was actually not a serie and subparts can be merged into it