Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the test adapter to support react 17 #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chelakis
Copy link

@chelakis chelakis commented Feb 1, 2022

Closes #211

Changed the adapter to work with react 17, changed react, react-dom versions and run the tests again with success

@ntarocco
Copy link
Contributor

ntarocco commented Feb 3, 2022

Thank you for this PR. We are discussing how to release it, because we cannot force react v17 at the moment in many other projects.

@avivace
Copy link
Member

avivace commented Feb 10, 2022

Thank you for this PR. We are discussing how to release it, because we cannot force react v17 at the moment in many other projects.

Great! Keep also in mind that react-overridable would also need to be bumped when there'll be a release supporting React 17. We have a PR there too: indico/react-overridable#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React 17
3 participants