Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React 17 #211

Open
avivace opened this issue Feb 1, 2022 · 1 comment · May be fixed by #212
Open

Support React 17 #211

avivace opened this issue Feb 1, 2022 · 1 comment · May be fixed by #212

Comments

@avivace
Copy link
Member

avivace commented Feb 1, 2022

To allow using searchkit in projects on React 17, we would need to upgrade react and react-dom dev and peer dependencies to ^17 and ensure test still run with success.

Anything else we should check?
@chelakis chelakis linked a pull request Feb 1, 2022 that will close this issue
Open
@rlreamy
Copy link

rlreamy commented Feb 4, 2022

I would love to have a version that I could use running on React v17. I looked at the comments on the PR and was wondering if you could publish a new version that runs on React v17 for people who have already migrated to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change the test adapter to support react 17 chelakis/react-searchkit
2 participants
@avivace @rlreamy