linter: allow expressions in JSX fragment #621
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
We get quite a lot of ESLint warnings across
inveniosoftware
repositories for following the pattern<>{foo}</>
.There are a few places were we explicitly inline-disable the check, and other places were we ignore the warning.
This pull request proposes to relax this ESLint rule to allow this pattern (see the
react/jsx-no-useless-fragment
documentation).If you agree with it, I will apply this change to:
inveniosoftware/eslint-config-invenio
(linter: allow expressions in JSX fragment & release: v2.0.2 eslint-config-invenio#16)inveniosoftware/demo-invenioils
(linter: allow expressions in JSX fragment demo-invenioils#17)inveniosoftware/cookiecutter-invenio-ils
(linter: allow expressions in JSX fragment cookiecutter-invenio-ils#3)Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: