Refactor roleneed roleid #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
reviewed
Jul 31, 2023
| def query_filter(self, identity=None, **kwargs): | ||
| """Filters for current identity.""" | ||
| for need in identity.provides: | ||
| if need.method == "role" and need.value == self.action.value: |
There was a problem hiding this comment.
shouldn't this be
Suggested change
| if need.method == "role" and need.value == self.action.value: | |
| if need.method == "action" and need.value == self.action.value: |
?
There was a problem hiding this comment.
I see from the tests that you add a role with a name equal to the action name....I might miss some knowledge on how the action roles work, but isn't creating an action redundant if we only check a role?
There was a problem hiding this comment.
Resolving as it was explained IRL
tests/conftest.py
Outdated
| "username": "user_moderator", | ||
| "email": "user_moderator@inveniosoftware.org", | ||
| "profile": { | ||
| "full_name": "Mr", |
There was a problem hiding this comment.
Suggested change
| "full_name": "Mr", | |
| "full_name": "Moderator", |
alejandromumo
force-pushed
the
refactor_roleneed_roleid
branch
from
22325a2
to
c0ae04e
Compare
alejandromumo
force-pushed
the
refactor_roleneed_roleid
branch
from
c0ae04e
to
5b5aade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes inveniosoftware/invenio-access#205
ATTENTION
This PR must be merged first.
If you review this PR, review only the last commit.