Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles: modify RoleNeed creation by role name to role id #205

Open
alejandromumo opened this issue Jul 27, 2023 · 1 comment · May be fixed by #206, inveniosoftware/flask-security-fork#54, inveniosoftware/invenio-requests#338, inveniosoftware/invenio-users-resources#94 or inveniosoftware/invenio-accounts#451
Open

roles: modify RoleNeed creation by role name to role id #205

alejandromumo opened this issue Jul 27, 2023 · 1 comment · May be fixed by #206, inveniosoftware/flask-security-fork#54, inveniosoftware/invenio-requests#338, inveniosoftware/invenio-users-resources#94 or inveniosoftware/invenio-accounts#451
Assignees
@ntarocco

Comments

@alejandromumo
Copy link
Member

Currently we rely on the role name to create a RoleNeed. Since the name can change, it's better to use the role's id.
This was referenced Jul 27, 2023
Open
Open
Open
Open
@alejandromumo
Copy link
Member Author

alejandromumo commented Jul 28, 2023 •
edited

This might break tests in other modules.

We can either fix them right away in this issue or have a pass afterwards.

@ntarocco ntarocco self-assigned this Aug 7, 2023
This was linked to pull requests Aug 8, 2023
wip: change roles db table inveniosoftware/invenio-accounts#432
Draft
models: add Role constructor to set id to name inveniosoftware/invenio-accounts#451
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntarocco ntarocco

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ntarocco @alejandromumo