Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Transfer registry #568

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mesemus
Copy link

@mesemus mesemus commented Mar 20, 2024

❤️ Thank you for your contribution!

Work in progress, not to be merged yet

Description

This pull request replaces TransferType enum with a dataclass, thus allowing to add other custom transfer types.
It also introduces a TransferRegistry to return instances of BaseTransfer implementation instead of hard-coded
if/then/else matching.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@mesemus mesemus changed the title Transfer registry implementation - initial commit WIP: Transfer registry Mar 20, 2024
@mesemus mesemus force-pushed the transfertype-registry branch 2 times, most recently from 20617ae to 9c8ee8e Compare March 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant