results: added support for drafts #1700
Conversation
| @@ -69,3 +69,32 @@ def get_value_service(self, value): | |||
| def pick(self, identity, resolved_rec): | |||
| """Pick fields defined in the entity resolver.""" | |||
| return resolved_rec | |||
|
|
|||
| class RDMRecordList(RecordList): | |||
There was a problem hiding this comment.
The issue was that drafts are searched through the records service, which in turn uses the default RecordList class to project the search results.
The default implementation uses self._service.record_cls unconditionally, which in turn projects the result always to a record. This is not correct if the service shares the search for records and drafts. For instance, an unpublished draft always had the attribute is_draft=False because the attribute is_draft of a Record is always set to False.
* Added support for drafts in the results list
alejandromumo
force-pushed
the
add_list_support_for_drafts
branch
from
ae88913
to
6cccfab
Compare
| for hit in self._results: | ||
| # Load dump | ||
| record_dict = hit.to_dict() | ||
| if record_dict["is_published"]: |
There was a problem hiding this comment.
minor: wouldn't it be better to rely on the is_draft property? Though I think this should be a ConstantField systemfield so that it makes it to the indexed document.
There was a problem hiding this comment.
I think that's what caused the issue in the first place. the "search" method can be used for drafts or records, however, the method lives inside the record's service. So using record.is_draft always returns False.
closes https://github.com/zenodo/ops/issues/340