metadata: auto-populate publication_date on new versions
#1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
slint
commented
Nov 28, 2023
•
slint
commented
- Closes https://github.com/zenodo/rdm-project/issues/588
| @@ -19,6 +20,9 @@ class MetadataComponent(ServiceComponent): | |||
|
|
|||
| field = "metadata" | |||
| new_version_skip_fields = ["publication_date", "version"] | |||
| new_version_generated_fields = { | |||
There was a problem hiding this comment.
minor: why not removing publication_date from new_version_skip_fields? It would simply import the previous version's publication date and then the user could modify it.
There was a problem hiding this comment.
I considered that initially, but this is how we had it in legacy and is the reason we ended up with many records that just had the exact same publication_date across all versions.
alejandromumo
approved these changes
Nov 30, 2023
Samk13
reviewed
Dec 10, 2023
Co-authored-by: Sam Arbid <36583694+Samk13@users.noreply.github.com>
lnielsen
approved these changes
Dec 12, 2023
|
This PR was automatically marked as stale. |
|
This PR was automatically marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.