Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIIF: set startCanvas from default_preview #1275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dfdan
Copy link
Member

@dfdan dfdan commented Apr 13, 2023

❤️ Thank you for your contribution!

Description

If a default preview file has been selected, this will be added as the manifest's startCanvas.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@dfdan dfdan requested a review from egabancho April 13, 2023 23:29
@github-actions
Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale label Jun 27, 2023
@dfdan dfdan removed the stale label Jun 27, 2023
@dfdan
Copy link
Member Author

dfdan commented Aug 22, 2023

rebased against master

@dfdan dfdan reopened this Aug 22, 2023
@dfdan
Copy link
Member Author

dfdan commented Aug 22, 2023

Rebased. IIIF tests passing, so this should be mergable once other issues causing test failures are resolved.

@github-actions
Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants