Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint problems #2662

Merged
merged 4 commits into from May 17, 2024
Merged

Conversation

ptamarit
Copy link
Member

@ptamarit ptamarit commented Apr 29, 2024

❤️ Thank you for your contribution!

Description

Every pull request in this repository shows inline ESLint annotations for these 4 problems:

  • 'SomeComponent' is defined but never used
  • 'someVariable' is assigned a value but never used
  • Do not use Array index in keys
  • Fragments should contain more than one child - otherwise, there’s no need for a Fragment at all

This pull requests solves the 3 4 first issues.
The 4th issue will be fixed by inveniosoftware/eslint-config-invenio#16.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ptamarit
Copy link
Member Author

Just rebased to fix a conflict on ShareModal.js, where the unused import has been removed in the meantime.

@ptamarit ptamarit requested a review from slint May 17, 2024 08:17
@slint slint merged commit 09ebcff into inveniosoftware:master May 17, 2024
2 checks passed
@ptamarit ptamarit deleted the fix-eslint-problems branch May 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants