Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change container height to min-height for responsiveness #2634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkloeppe
Copy link

@mkloeppe mkloeppe commented Apr 4, 2024

Description

Having long community names in German names often overlap the boundaries of the container. Changing height to min-height allows the container to grow if the community name is longer.

Screenshots

Actual state

image

Target state

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@SarahW91 SarahW91 requested a review from kpsherva April 4, 2024 09:36
@mkloeppe mkloeppe self-assigned this Apr 22, 2024
@mkloeppe mkloeppe added the UI label Apr 22, 2024
@kpsherva
Copy link
Contributor

kpsherva commented May 2, 2024

looks good, could you though attach a screenshot of how the change influences the box?

@mkloeppe
Copy link
Author

mkloeppe commented May 3, 2024

Added screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants