Mirador Test Previewer #2550
Draft
Mirador Test Previewer #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Dec 14, 2023
| @@ -10,7 +10,7 @@ | |||
| #} | |||
|
|
|||
|
|
|||
| {%- macro preview_file(preview_endpoint, pid_value, filename, is_preview, include_deleted, id='preview-iframe', width='100%', height='400' ) %} | |||
| {%- macro preview_file(preview_endpoint, pid_value, filename, is_preview, include_deleted, id='preview-iframe', width='100%', height='800' ) %} | |||
There was a problem hiding this comment.
we are changing the default height for all previewers here, not only Mirador. Is this what we want?
There was a problem hiding this comment.
400px is pretty small, so making it bigger for everyone might be something desirable. See e.g. https://new-cds.cern.ch/records/fp18d-jc149:
We have to be a bit careful on mobile though, it's a bit difficult to touch/scroll at the right place to get past the previewer:
We should probably rewrite to use CSS classes for styling, with 80vh or similar (that way anyone can override also on their instance).
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/mirador_preview.html
Outdated
Show resolved
Hide resolved
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/mirador_preview.html
Outdated
Show resolved
Hide resolved
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/mirador_preview.html
Outdated
Show resolved
Hide resolved
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/mirador_preview.html
Outdated
Show resolved
Hide resolved
|
This PR was automatically marked as stale. |
slint
force-pushed
the
Mirador-Previewer
branch
from
85463eb
to
26e66cd
Compare
slint
force-pushed
the
Mirador-Previewer
branch
from
01c5689
to
8900578
Compare
0einstein0
added
enhancement
Samk13
reviewed
Apr 18, 2024
0einstein0
force-pushed
the
Mirador-Previewer
branch
from
0077dfc
to
a632fb6
Compare
0einstein0
force-pushed
the
Mirador-Previewer
branch
from
a25f1c2
to
d9829b2
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Testing integration of Mirador Previewer
Closes Issue zenodo/zenodo-rdm#819
Depends on: #2652
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: