Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIIF: config changes #2360

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

IIIF: config changes #2360

wants to merge 3 commits into from

Conversation

dfdan
Copy link
Member

@dfdan dfdan commented Aug 22, 2023

❤️ Thank you for your contribution!

Description

A couple of minor tweaks to IIIF configuration.

I'm sure someoen will have a better way to make sure that RECORDS_RESOURCES_IMAGE_FORMATS and IIIF_FORMATS agree, I will mark this as a draft and welcome comments.

requires invenio-records-resources#484

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

- put pdfjs before iiif-simple to make it harder to try and preview PDFs with IIIF
- remove un-needed value in IIIF_FORMATS_PIL_MAP
@dfdan dfdan marked this pull request as draft August 22, 2023 19:18
@dfdan dfdan requested a review from slint August 22, 2023 19:18
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dfdan dfdan marked this pull request as ready for review August 23, 2023 08:16
@github-actions
Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Oct 23, 2023
@slint slint removed the stale No activity for more than 60 days. label Oct 26, 2023
Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity for more than 60 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants