Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer: prevent footer overflow on short pages #2184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfdan
Copy link
Member

@dfdan dfdan commented Apr 4, 2023

❤️ Thank you for your contribution!

Description

Add padding to .footer-bottom to prevent footer from overflowing. Closes #2183.

Before:
Screenshot 2023-04-04 at 12 37 18

After:
Screenshot 2023-04-04 at 15 16 05

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@kpsherva
Copy link
Contributor

kpsherva commented Apr 5, 2023

Thank you for the fix, looks good to me!
The PR needs a rebase though, otherwise there are some previous commits and conflicts

@dfdan dfdan changed the title Fix footer overflow Footer: prevent footer overflow on short pages Apr 11, 2023
@dfdan
Copy link
Member Author

dfdan commented Apr 11, 2023

Rebased against master.

@github-actions
Copy link
Contributor

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity for more than 60 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Footer always overflows vertically
2 participants