Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Footer always overflows vertically #2183

Open
dfdan opened this issue Apr 4, 2023 · 1 comment · May be fixed by #2184
Open

UX: Footer always overflows vertically #2183

dfdan opened this issue Apr 4, 2023 · 1 comment · May be fixed by #2184
Labels
bug Something isn't working stale No activity for more than 60 days.

Comments

@dfdan
Copy link
Member

dfdan commented Apr 4, 2023

Package version (if known): V11 and previous.

Describe the bug

On any RDM page the footer overflows vertically slighty - even if the page doesn't contain enough content to require scrolling. This looks a bit messy and obscures the footer. Confirmed in FF/Chrome/Safari.

Steps to Reproduce

  1. See images below, can be made to occur on any page with minimal content (we see this for example when creating minimal landing pages)

Expected behavior

Footer should not overflow vertically / page should not require scrolling if content doesn't require it.

Screenshots (if applicable)

Screenshot 2023-04-04 at 12 37 18

Note that even with no content in the main div, the footer overflows vertically.
This appears to be becuase of the vertical padding in the columns in the lower footer:

Screenshot 2023-04-04 at 12 37 50

Screenshot 2023-04-04 at 12 38 26

I have a possible fix and will make a PR.

@dfdan dfdan added the bug Something isn't working label Apr 4, 2023
@dfdan dfdan linked a pull request Apr 4, 2023 that will close this issue
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No activity for more than 60 days.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant