items: Add identifiers object list field #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Apr 8, 2024
| from marshmallow import EXCLUDE, Schema, fields | ||
|
|
||
|
|
||
| class IdentifiersSchema(Schema): |
There was a problem hiding this comment.
this schema already exists under document.py, it would be better to reuse it than create a duplicate
|
General: it looks we are missing the identifier schemes json update, to add a new identifier schema type ("call_number", which appears in the production script PR) |
kpsherva
approved these changes
Apr 19, 2024
kpsherva
reviewed
May 13, 2024
| @@ -16,6 +16,7 @@ | |||
| set_changed_by, | |||
| ) | |||
| from invenio_app_ils.records.loaders.schemas.price import PriceSchema | |||
| from invenio_app_ils.documents.loaders.jsonschemas.document import IdentifierSchema | |||
There was a problem hiding this comment.
Identifiers schema to be moved to records.loaders (like above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Closes: CERNDocumentServer/cds-ils#834