Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Implement sensitivities for the QR decomposition #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ararslan
Copy link
Collaborator

No one asked for this, this is just something I do now for fun, apparently.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #165 into master will decrease coverage by 0.43%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   97.06%   96.62%   -0.44%     
==========================================
  Files          20       21       +1     
  Lines         749      770      +21     
==========================================
+ Hits          727      744      +17     
- Misses         22       26       +4
Impacted Files Coverage Δ
src/Nabla.jl 100% <ø> (ø) ⬆️
src/sensitivities/linalg/factorization/qr.jl 80.95% <80.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b119b...e44a59e. Read the comment docs.

Copy link
Contributor

@eperim eperim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to have the links to the papers as comments, so it is easy for people to check where this came from.

)
Q, R = Y
Q̄, R̄ = Ȳ
triu!(R̄)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is not necessarily triangular, this should go.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants