Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify label configuration #751

Merged
merged 10 commits into from Dec 7, 2019
Merged

Simplify label configuration #751

merged 10 commits into from Dec 7, 2019

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Dec 5, 2019

Release Notes

Label configuration just got a whole lot simpler 🎉

  1. Labels can now only be supplied as an array of label objects.
{
  "labels": [
    { "releaseType": "major", "name": "Version: Major" },
    { "releaseType": "minor", "name": "Version: Minor" },
    { "releaseType": "patch", "name": "Version: Patch" },
  ]
}
  1. Instead of using skipReleaseLabels just set the label's type to skip
{
  "labels": [
    { "releaseType": "skip", "name": "NO!" }
  ]
}
  1. Overwrite default labels using overwrite
{
  "labels": [
    { "releaseType": "major", "name": "Version: Major", "overwrite": true },
  ]
}
  1. Add none releaseType. This will act as a skip-release unless paired with a SEMVER label
{
  "labels": [
    { "releaseType": "none", "name": "documentation" },
  ]
}
  1. Changed title to changelogTitle.
{
  "labels": [
    { "changelogTitle": "New Docs Yo!", "name": "documentation" },
  ]
}

Why

closes #541
closes #476

Todo:

  • Add tests
  • Add docs

Published PR with canary version: 8.0.0-canary.751.9964.0

@hipstersmoothie hipstersmoothie added the major Increment the major version when merged label Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (next@575d319). Click here to learn what that means.
The diff coverage is 83.9%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #751   +/-   ##
=======================================
  Coverage        ?   84.83%           
=======================================
  Files           ?       38           
  Lines           ?     2275           
  Branches        ?      313           
=======================================
  Hits            ?     1930           
  Misses          ?      292           
  Partials        ?       53
Impacted Files Coverage Δ
packages/cli/src/parse-args.ts 100% <ø> (ø)
packages/core/src/auto.ts 85.27% <100%> (ø)
packages/core/src/release.ts 96.08% <100%> (ø)
plugins/slack/src/index.ts 97.61% <100%> (ø)
packages/core/src/init.ts 20.4% <25%> (ø)
packages/core/src/semver.ts 88.88% <60%> (ø)
packages/core/src/git.ts 90.94% <66.66%> (ø)
packages/core/src/config.ts 91.17% <80.95%> (ø)
packages/core/src/changelog.ts 96.59% <84.61%> (ø)
plugins/released/src/index.ts 92.42% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575d319...49a6190. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit eaf54ec into next Dec 7, 2019
@hipstersmoothie hipstersmoothie deleted the skip-release-label branch December 7, 2019 01:08
@adierkens adierkens added the prerelease This change is available in a prerelease. label Dec 7, 2019
@hipstersmoothie hipstersmoothie mentioned this pull request Dec 10, 2019
@adierkens
Copy link
Collaborator

🚀 PR was released in v8.0.0 🚀

@adierkens adierkens added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants