Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate skipReleaseLabels #541

Closed
hipstersmoothie opened this issue Aug 31, 2019 · 6 comments
Closed

Deprecate skipReleaseLabels #541

hipstersmoothie opened this issue Aug 31, 2019 · 6 comments
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects

Comments

@hipstersmoothie
Copy link
Collaborator

With the ability to specify an array of labels for any of the default labels skipReleaseLabels is unnecessary

@hipstersmoothie hipstersmoothie added the major Increment the major version when merged label Aug 31, 2019
@zephraph
Copy link
Collaborator

Cool, so while not exactly what I'd proposed in #476, this is definitely heading in a positive direction.

Just so I understand...

There's now major, minor, patch, and skip-release sections in labels that can have multiple different labels. Does it make sense to support any other labels?

@hipstersmoothie
Copy link
Collaborator Author

I'd still like to be able to have custom changelog title labels. I think it still makes sense to support them, but maybe more in the way that you describe in #476

@hipstersmoothie hipstersmoothie added this to Todo in V8 Aug 31, 2019
@zephraph
Copy link
Collaborator

zephraph commented Sep 1, 2019

@hipstersmoothie, the thing I'm struggling to wrap my head around is how does (or should) a label that's only responsibility is changing the changelog interact with labels whose job it is to do a release... And what's the value in having those two things as fundamentally different?

So if you wanted to say... have a typescript changelog label. When you add that label, does it just create a duplicate section in the changelog with typescript grouped under it? Or does it override the other label. If it overrides, wouldn't it be weird to have a typescript section in the changelog that could've resulted in a major, minor, or patch release? That just feels... weird to me.

Conceptually I just feel like it'd be simpler if we had only four types of releases, but you could have multiple of those releases (and the changelog titles could be altered for each).

So if you have a typescript label, it could set the changelog title to typescript and do a minor release.

@hipstersmoothie
Copy link
Collaborator Author

When you add that label, does it just create a duplicate section in the changelog with typescript grouped under it? Or does it override the other label.

Overrides the other label but is organized in the same order prefereably

# Major
# Minor 
# Typescript (minor)
# Patch

Conceptually I just feel like it'd be simpler if we had only four types of releases, but you could have multiple of those releases (and the changelog titles could be altered for each).

What would this type of changelog look like?

@zephraph
Copy link
Collaborator

zephraph commented Sep 3, 2019

The changelog would look the same as it does today. Just given your above example you'd have to have...

labels: [
  {
    label: "New Types",
    releaseType: "minor",
    changelogTitle: "Typescript (minor)"
  }
]

Idk, ha. This changelog stuff is pretty hairy. I'm good with whatever, but ideally we just keep it as simple as possible.

@adierkens adierkens added the prerelease This change is available in a prerelease. label Dec 7, 2019
@adierkens
Copy link
Collaborator

🚀 Issue was released in v8.0.0 🚀

@adierkens adierkens added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Dec 12, 2019
@hipstersmoothie hipstersmoothie moved this from Todo to Completed in V8 Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
No open projects
V8
Completed
Development

No branches or pull requests

3 participants