Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix #1314 - security.txt full url in finding #1319

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bwbroersma
Copy link
Collaborator

@bwbroersma bwbroersma commented Mar 10, 2024

Fixes #1314.

In develop I have to run python3 manage.py migrate, I thought db-migrate should do this automatically?

I'm having some trouble with the translation files and how to update the django.po from the main.po (I know there is the content repo) by running python3 bin/pofiles.py to_django / python3 manage.py compilemessages.
The current content change is:

$ sed -r -i 's/(security.txt )(retrieved from|opgehaald van)( \{hostname)/\1\2 {url/'

@bwbroersma bwbroersma force-pushed the gh1314-sectxt-full-url-finding branch 3 times, most recently from f1901cc to af11a77 Compare March 10, 2024 22:35
@mxsasha
Copy link
Collaborator

mxsasha commented Mar 11, 2024

The translation files are exclusively managed through the content repo. Updates directly to the translation files will be overwritten when we do a content update. I don't think you need to update django.po yourself, it's not in the repo, I am pretty sure it's generated in the Dockerfile.

For the API, we also need to update openapi.yaml and bump the API version.

bwbroersma and others added 2 commits March 15, 2024 10:09
@mxsasha mxsasha force-pushed the gh1314-sectxt-full-url-finding branch from 1c08584 to 40bc16c Compare March 15, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Show full URL of retrieved security.txt file instead of just host
2 participants