Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Nginx more specific server_name #1179

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP Nginx more specific server_name #1179

wants to merge 1 commit into from

Conversation

bwbroersma
Copy link
Collaborator

Partly fixes #1175

@bwbroersma
Copy link
Collaborator Author

${INTERNETNL_DOMAINNAME} should not be used in a regex, maybe add a REGEX_ESCAPED version of INTERNETNL_DOMAINNAME, in normal domain names only the . is a realistic problem, so maybe call it DOT_ESCAPED to be correct:

DOT_ESCAPED_INTERNETNL_DOMAINNAME="${INTERNETNL_DOMAINNAME//\./\\.}"

@bwbroersma bwbroersma force-pushed the gh-1179-nginx-more-specific-server_name branch 3 times, most recently from d6fe966 to cd3c030 Compare November 14, 2023 19:41
@bwbroersma @mxsasha
Nginx more specific server_name
3f2b82d 
Partly fixes internetstandards#1175

Signed-off-by: Benjamin W. Broersma <bw@broersma.com>
@mxsasha mxsasha force-pushed the gh-1179-nginx-more-specific-server_name branch from cd3c030 to 3f2b82d Compare November 15, 2023 15:36
@bwbroersma bwbroersma mentioned this pull request Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serve 404's on / requests for http://ns.test-ns-signed.internet.nl
1 participant
@bwbroersma