Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display cover as comment in Recent Changes Table #5716

Merged
merged 3 commits into from Jan 6, 2022

Conversation

Yashs911
Copy link
Contributor

@Yashs911 Yashs911 commented Oct 3, 2021

Closes #29

Display newly added cover as comment in Recent Changes Table

Technical

Please check for any edge cases I missed.

Testing

  1. Edit cover locally
  2. Go to http://localhost:8080/recentchanges and check

Screenshot

image

Stakeholders

@jimchamp @mekarpeles

@Yashs911 Yashs911 changed the title Display new added cover as comment in Recent Changes Table Display cover as comment in Recent Changes Table Oct 3, 2021
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 28, 2021
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks @Yashs911!

@jimchamp jimchamp merged commit ec46251 into internetarchive:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"add-cover" edits in Recent Changes table should display Cover as comment (for review)
2 participants