Move oldump.sh from olsystem in scripts #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes: - Abstract any potential secrets - Abstract to work with directory structure in local environment - Remove some dead comments about "normalized"/"denormalized" dump
cdrini
force-pushed
the
refactor/move-oldump
branch
from
57f3b0b
to
b191d59
Compare
cdrini
added
Priority: 1
|
The olsystem PR got merged; this needs to be merged before next deploy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3990 . Need a way to easily test the flow, and right now can't easily run the oldump locally. A follow up PR in olsystem will remove the file there: https://github.com/internetarchive/olsystem/pull/135.
Technical
Testing
Generates dump files in ./dumps/dumps, and sitemaps in ./dumps/sitemaps (there are already in gitignore)
Screenshot
Stakeholders
@mekarpeles