Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase search bar component z-index #3801

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

jimchamp
Copy link
Collaborator

Closes #3796

Corrects issue where work menu overlaps search results if several results are displayed.

Technical

Increased the z-index of the search bar component. The z-index of the work menu and the search bar component were equal before this change.

Testing

Screenshot

Screenshot from 2020-09-14 12-50-17

Stakeholders

@cdrini cdrini self-assigned this Sep 15, 2020
@cdrini cdrini added the On Dev label Sep 15, 2020
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @jamesachamp ! Confirmed working on dev.openlibrary.org
image

Also tested the hover menus work correctly.

@cdrini cdrini merged commit fbea07f into internetarchive:master Sep 15, 2020
@jimchamp jimchamp deleted the 3796/bug/fix-menu-overlap branch September 18, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search result preview overlapping with other page elements
2 participants