Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search result preview overlapping with other page elements #3796

Closed
bitnapper opened this issue Sep 13, 2020 · 6 comments · Fixed by #3801 or #4556
Closed

Search result preview overlapping with other page elements #3796

bitnapper opened this issue Sep 13, 2020 · 6 comments · Fixed by #3801 or #4556
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Module: Books Page Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@bitnapper
Copy link

Typing a search request with plenty of hits into the top search-field, waiting for the preview results. The result bar (could not figure out the id) is overlapped by <ul class="work-menu sticky">.

Evidence / Screenshot (if possible)

Screenshot_2020-09-13 The Girl, the Gold Watch and Everything (1962 edition) Open Library

Steps to Reproduce

  1. Go to any page and type 'Girl, the Gold Watch' into the upper search bar and just wait
  2. when the preview results appear, you should see the problem
  • Logged in: not relevant
  • Browser type/version? firefox
  • Operating system? osx
  • Environment? prod

Proposal & Constraints

Related files

Stakeholders
@bitnapper bitnapper added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Sep 13, 2020
@jimchamp
Copy link
Collaborator

The search results are in <div class="search-bar-component">. Both the search bar component and the work menu have the same z-index (999). It looks like increasing the search bar component's z-index will correct this.

I'll raise a PR for this tomorrow, as it's a bit late here now.

@jimchamp jimchamp mentioned this issue Sep 14, 2020
Merged
@bitnapper bitnapper changed the title Search rusult preview overlapping with other page elements Search result preview overlapping with other page elements Sep 14, 2020
@xayhewalo xayhewalo added Affects: UI Issues with the web site's user interface. [managed] Module: Books Page Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Sep 15, 2020
@xayhewalo
Copy link
Collaborator

I recall seeing this bug before, but can't find the issue. If anyone has better memory than me mention the issue in this thread

@xayhewalo
Copy link
Collaborator

@cdrini I'm still seeing this bug why was this closed?

@cdrini
Copy link
Collaborator

cdrini commented Sep 15, 2020

Fixed on dev :) Deploying today

@cclauss
Copy link
Collaborator

cclauss commented Feb 8, 2021

This seems to be occurring again.

@cclauss cclauss reopened this Feb 8, 2021
@Yashs911
Copy link
Contributor

Yashs911 commented Feb 8, 2021

I would like to work on this

@Yashs911 Yashs911 mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Module: Books Page Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
6 participants
@bitnapper @cclauss @cdrini @xayhewalo @jimchamp @Yashs911